Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material/list): update a11y documention on radio indicators #26374

Merged
merged 1 commit into from Jan 10, 2023
Merged

docs(material/list): update a11y documention on radio indicators #26374

merged 1 commit into from Jan 10, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jan 5, 2023

Update the accessibility section on radio indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for #25933 and
#26283.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/list labels Jan 5, 2023
@zarend zarend requested a review from jelbourn January 5, 2023 19:38
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 5, 2023
@zarend zarend marked this pull request as draft January 6, 2023 17:27
@devversion devversion removed their request for review January 9, 2023 13:56
@zarend zarend marked this pull request as ready for review January 10, 2023 04:53
@zarend zarend added the target: minor This PR is targeted for the next minor release label Jan 10, 2023
mmalerba
mmalerba reviewed Jan 10, 2023
View reviewed changes
src/material/list/list.md Outdated Show resolved Hide resolved
mmalerba
mmalerba reviewed Jan 10, 2023
View reviewed changes
src/material/list/list.md Outdated Show resolved Hide resolved
mmalerba
mmalerba approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one grammar nit

src/material/list/list.md Outdated Show resolved Hide resolved
@zarend
docs(material/list): update a11y documention on radio indicators
468ad3c 
Update the accessibility section on radio indicators for
single-selection. Add instructions to always communicate selection with
icon indicators. Fulfill documentation needs as follow-up for angular#25933 and
 angular#26283.
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2023
@angular-robot angular-robot bot merged commit 60d5bdc into angular:main Jan 10, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/list docs This issue is related to documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarend @jelbourn @mmalerba