Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/global-listener): initial global listener implementation #26314

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(cdk/global-listener): initial global listener implementation #26314

wants to merge 3 commits into from

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 22, 2022
@wagnermaciel wagnermaciel added the target: major This PR is targeted for the next major release label Dec 22, 2022
@wagnermaciel wagnermaciel marked this pull request as ready for review December 22, 2022 22:16
@wagnermaciel wagnermaciel requested review from mmalerba and removed request for josephperrott and andrewseguin December 22, 2022 22:16
crisbeto
crisbeto reviewed Dec 23, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any context behind why this new package is being introduced? It doesn't look like it's used anywhere.

@wagnermaciel
Copy link
Contributor Author

Yeah, we're having some scalability issues with applications that have hundreds of the same component on the same page. One of the issues is the number of independent event listeners being attached. I still need to do some experimenting internally to see if this actually alleviates the issue

@crisbeto
Copy link
Member

Do we have any concrete examples where this would help though? We generally don't want to implement our own event management on top of the framework.

I suspect that we got rid of a lot of the listeners in #26147.

@devversion devversion removed their request for review January 16, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

@mmalerba mmalerba Awaiting requested review from mmalerba

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wagnermaciel @crisbeto