Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): better handling of css variables in theme palettes #26260

Merged
merged 1 commit into from Dec 14, 2022

Commits on Dec 14, 2022

  1. fix(material/core): better handling of css variables in theme palettes

    Technically we don't support theming using CSS variables, but the community has started depending on it anyway since it happened to work. This was broken during the switch to MDC which is blocking users from updating to v15.
    
    These changes make a best effort to avoid all the errors and reduce the amount of warnings as much as possible.
    
    A couple of disclaimers:
    * All the places where we were manipulating colors are going to compile now, but they might not look great. This is only going to affect some MDC components though, the legacy components will work as expected.
    * One warning might be logged from the themes for components based on MDC's list. They will compile and look acceptable, but I couldn't find a good way to avoid the error with our current setup. We will be able to avoid the warning once we switch the components to the token theming APIs.
    
    Relates to angular#25981.
    crisbeto committed Dec 14, 2022
    Copy the full SHA
    cd95c32 View commit details
    Browse the repository at this point in the history