Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/form-field): allow getting harness by validity #26232

Merged
merged 2 commits into from Dec 13, 2022
Merged

fix(material/form-field): allow getting harness by validity #26232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3475e30
fix(material/form-field): allow getting harness by validity
mmalerba Dec 9, 2022
7b2e728
fixup! fix(material/form-field): allow getting harness by validity
mmalerba Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/material/form-field/testing/form-field-harness-filters.ts
View file
Open in desktop
Expand Up @@ -14,4 +14,6 @@ export interface FormFieldHarnessFilters extends BaseHarnessFilters {
floatingLabelText?: string | RegExp;
/** Filters based on whether the form field has error messages. */
hasErrors?: boolean;
/** Filters based on whether the form field value is valid. */
isValid?: boolean;
}
5 changes: 5 additions & 0 deletions src/material/form-field/testing/form-field-harness.ts
View file
Open in desktop
Expand Up @@ -248,6 +248,11 @@ export class MatFormFieldHarness extends _MatFormFieldHarnessBase<
'hasErrors',
options.hasErrors,
async (harness, hasErrors) => (await harness.hasErrors()) === hasErrors,
)
.addOption(
'isValid',
options.isValid,
async (harness, isValid) => (await harness.isControlValid()) === isValid,
);
}

Expand Down
11 changes: 11 additions & 0 deletions src/material/form-field/testing/shared.spec.ts
View file
Open in desktop
Expand Up @@ -197,6 +197,17 @@ export function runHarnessTests(
);
});

it('should be able to get form-field by validity', async () => {
let invalid = await loader.getAllHarnesses(formFieldHarness.with({isValid: false}));
expect(invalid.length).toBe(0);

fixture.componentInstance.requiredControl.setValue('');
dispatchFakeEvent(fixture.nativeElement.querySelector('#with-errors input'), 'blur');

invalid = await loader.getAllHarnesses(formFieldHarness.with({isValid: false}));
expect(invalid.length).toBe(1);
});

it('should be able to get error harnesses from the form-field harness', async () => {
const formFields = await loader.getAllHarnesses(formFieldHarness);
expect(await formFields[1].getErrors()).toEqual([]);
Expand Down
5 changes: 5 additions & 0 deletions src/material/legacy-form-field/testing/form-field-harness.ts
View file
Open in desktop
Expand Up @@ -57,6 +57,11 @@ export class MatLegacyFormFieldHarness extends _MatFormFieldHarnessBase<
'hasErrors',
options.hasErrors,
async (harness, hasErrors) => (await harness.hasErrors()) === hasErrors,
)
.addOption(
'isValid',
options.isValid,
async (harness, isValid) => (await harness.isControlValid()) === isValid,
);
}

Expand Down
1 change: 1 addition & 0 deletions tools/public_api_guard/material/form-field-testing.md
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@ export type FormFieldControlHarness = MatInputHarness | MatSelectHarness | MatDa
export interface FormFieldHarnessFilters extends BaseHarnessFilters {
floatingLabelText?: string | RegExp;
hasErrors?: boolean;
isValid?: boolean;
}

// @public
Expand Down