Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(material/core): delegate trigger events #26147

Merged
merged 1 commit into from Dec 2, 2022
Merged

perf(material/core): delegate trigger events #26147

merged 1 commit into from Dec 2, 2022

Commits on Dec 2, 2022

  1. perf(material/core): delegate trigger events 

    Ripples are used a lot throughout our components which makes them very performance-sensitive. These changes aim to reduce the cost of setting them up by delegating the `mousedown` and `touchstart` handlers. This shaved off 15 to 20 percent of the creation cost from buttons.

I decided to only delegate the `mousedown` and `touchstart` events, rather than all ripple-related events, because ripples listen to some very frequent events like `mouseleave` and the cost of matching events to their targets would've offset any gains we would've gotten from delegating them. The code is written in a way where we can easily delegate them later if we change our minds.
    @crisbeto
    crisbeto committed Dec 2, 2022
    Copy the full SHA
    bf29f1c View commit details
    Browse the repository at this point in the history