Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/list): align color scheme between single and multi selection list #26074

Merged
merged 1 commit into from Dec 5, 2022
Merged

fix(material/list): align color scheme between single and multi selection list #26074

merged 1 commit into from Dec 5, 2022

Commits on Dec 3, 2022

  1. fix(material/list): align color scheme between single and multi selec… 

    …tion list

MDC has the `mdc-list-item--selected` class which we were setting only on single selection `mat-list-option` to indicate using color that they're selected. After the recent change to indicate selection using a radio button, these look weird because the radio button inherits the list item theme palette while the background of the item stays as `primary`.

These changes resolve the issue by treating single selection and multi-selection lists the same.

**Note:** an alternative I was considering was to change the color so that it matches the radio button color, but then the appearance of the single selection list would be inconsistent with the multi-selection list.
    @crisbeto
    crisbeto committed Dec 3, 2022
    Copy the full SHA
    e720d89 View commit details
    Browse the repository at this point in the history