Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/progress-bar): do not adjust color if it is not defined as a color #26017

Closed
wants to merge 1 commit into from
Closed

fix(material/progress-bar): do not adjust color if it is not defined as a color #26017

wants to merge 1 commit into from

Conversation

alorle
Copy link

@alorle alorle commented Nov 18, 2022

Do not adjust color if the $color resolved to something different from a color (e.g. a CSS variable).

This is a regression. It was introduced in f384c24 and fixes #25981

…as a color

Do not adjust color when setting track-color if given argument is not a
color, for example, a CSS variable.
@alorle alorle marked this pull request as draft November 18, 2022 10:28
@if (meta.type-of($color) == 'color') {
@return color.adjust($color, $alpha: -0.75);
}
@return $color;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any CSS expert help me figure out how to change the alpha channel of this color keeping in mind that it can be any type of color (HSL, RGB, RGBA, hex, etc)?

@alorle alorle closed this Nov 21, 2022
@alorle
Copy link
Author

alorle commented Nov 21, 2022

Testing all the possibilities for the progress-bar (buffer, query, indeterminate...), I have seen that using CSS variables has many adverse effects, therefore, I have closed the PR, since it does not correct the problem at all.

I think this can only be resolved when material-components/material-components-web#4709 is resolved.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(theming): WARNING: var(--primary, #4bcd3e) is not a color. Falling back to "dark" tone.
2 participants