fix(cdk-experimental/menu): simplify radio and checkbox item APIs #24720
+125
−511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Apr 4, 2022
| @@ -1145,7 +1112,7 @@ describe('MenuBar', () => { | |||
| template: ` | |||
| <ul cdkMenuBar> | |||
| <li role="none"> | |||
| <button checked="true" cdkMenuItemRadio> | |||
| <button cdkMenuItemChecked="true" cdkMenuItemRadio> | |||
There was a problem hiding this comment.
I can see this going either way, but maybe we can make this [cdkMenuItemRadio]="isChecked" since that's the most common usage for the directive.
There was a problem hiding this comment.
I see the appeal because its less verbose, though if we do that there are some examples that feel weird:
<div cdkMenuItemRadio>- is checked, as a user I would probably expect unchecked<div cdkMenuItemRadio="false">- sounds it should make it behave like not a radio button or something
There was a problem hiding this comment.
Yeah that's also a good point, especially if we end up coercing the input. Up to you if you want to change it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.