fix(cdk-experimental/menu): move shared menu logic to base class #24645
+334
−351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
commented
Mar 22, 2022
jelbourn
reviewed
Mar 23, 2022
mmalerba
force-pushed
the
cdk-menu
branch
3 times, most recently
from
27c04ed to
8784cee
Compare
crisbeto
reviewed
Mar 24, 2022
fix(cdk-experimental/menu) make trigger items behave like normal items when pressing left/right
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…ular#24645) * fix(cdk-experimental/menu): move shared menu logic to base class fix(cdk-experimental/menu) make trigger items behave like normal items when pressing left/right * fixup! fix(cdk-experimental/menu): move shared menu logic to base class * fixup! fix(cdk-experimental/menu): move shared menu logic to base class
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TODOs for a couple questions I had as I was going. I can address them in this PR or a followup