Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): fix failing unit test in multiyear view #24418

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix(material/datepicker): fix failing unit test in multiyear view #24418

merged 1 commit into from
Feb 15, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 15, 2022 •
edited

Fixes the recent CI failures. Please see commit message for description.

@zarend zarend added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release area: material/datepicker labels Feb 15, 2022
wagnermaciel
wagnermaciel approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend
fix(material/datepicker): fix failing unit test in multiyear view
09abea1 
Fix a failing unit test, which was referencing Jan 1, 2017 as the initial
date when it is actually Jan 3, 2017. This happened as a result of a bad
merge where angular#24384 changed the initial date to Jan 3, and angular#24401 added a
new test that assume the initial date was Jan 1.

Fixes CI failure
@zarend zarend changed the title refactor(material/datepicker): fix failing unit test fix(material/datepicker): fix failing unit test in multiyear view Feb 15, 2022
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 15, 2022
@zarend zarend merged commit 5603d9b into angular:master Feb 15, 2022
This was referenced Feb 25, 2022
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 18, 2022
@zarend zarend deleted the fix-jan-3-datepicker-test branch March 29, 2022 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/datepicker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zarend @wagnermaciel