fix(material/tabs): allow coercing of booleans for all inputs #24377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeripeierSBB
force-pushed
the
tabs-coerce-boolean
branch
4 times, most recently
from
0d0da2a
to
e68f1ba
Compare
Previously, some properties were declared as BooleanInput and some not. With this commit, all boolean inputs are threat as BooleanInput and therefore the input values are being coerced.
jeripeierSBB
force-pushed
the
tabs-coerce-boolean
branch
from
e68f1ba
to
23b6b5d
Compare
crisbeto
added
action: merge
wagnermaciel
added
target: minor
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…r#24377) Previously, some properties were declared as BooleanInput and some not. With this commit, all boolean inputs are threat as BooleanInput and therefore the input values are being coerced.
|
@wagnermaciel @crisbeto @josephperrott The tabs preserve content example is now broken because somehow the examples got released with version 13.2.3 but the commit of the code changes was not in release 13.2.3 but only in 14.0.0-next.3. |
|
@jeripeierSBB Yeah, looks like the v14 docs content/example content is used for the v13 material docs site. I'll send a fix in angular/material.angular.io. |
This was referenced Feb 25, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some properties were declared as BooleanInput and some not. With this commit, all boolean inputs are threat as BooleanInput and therefore the input values are being coerced.