Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/chips): update chip-list describedby to match input #24292

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

RobertAKARobin
Copy link
Contributor

@RobertAKARobin RobertAKARobin commented Jan 27, 2022

Updates MatChipList to be consistent with MatInput, and fixes ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field, e.g.

<mat-form-field>
    <ng-content select="mat-chip-list"></ng-content>
    <mat-hint>foo</mat-hint>
</mat-form-field>

My use-case was creating a wrapper around mat-form-field to house various Mat-* formcontrol types.

MatSelect could use the same update.

@RobertAKARobin RobertAKARobin changed the title feat(material/chip-list): update chip-list describedby to match input feat(material/chips): update chip-list describedby to match input Jan 27, 2022
@RobertAKARobin RobertAKARobin requested a review from a team as a code owner January 27, 2022 14:16
Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Really another feature as part of this PR is that users are now able to add additional
accessibility descriptions (through aria-describedby) on the select, without it being accidentally overidden.

cc. @crisbeto for an additional review.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 31, 2022
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 14, 2022
@wagnermaciel wagnermaciel merged commit 06e65c6 into angular:master Feb 14, 2022
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
…gular#24292)

Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants