Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/text-field): handle undefined placeholder #24159

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix(cdk/text-field): handle undefined placeholder #24159

merged 1 commit into from
Jan 6, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 4, 2022

Fixes that the string "undefined" would be used as the placeholder of an autosize textarea if the value is undefined.

Fixes #24154.

@crisbeto
fix(cdk/text-field): handle undefined placeholder
6838f0f 
Fixes that the string "undefined" would be used as the placeholder of an autosize `textarea` if the value is `undefined`.

Fixes angular#24154.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 4, 2022
@crisbeto crisbeto requested a review from mmalerba January 4, 2022 08:01
@crisbeto crisbeto mentioned this pull request Jan 4, 2022
Closed
1 task
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 4, 2022
@wagnermaciel wagnermaciel merged commit 93e09c6 into angular:master Jan 6, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 6, 2022
@crisbeto @wagnermaciel
fix(cdk/text-field): handle undefined placeholder (#24159)
7705cae 
Fixes that the string "undefined" would be used as the placeholder of an autosize `textarea` if the value is `undefined`.

Fixes #24154.

(cherry picked from commit 93e09c6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/text-field): material text area input placeholder shows 'undefined' when using cdkTextareaAutosize
3 participants
@crisbeto @mmalerba @wagnermaciel