Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slide-toggle): remove aria-required rather than setting to false #24105

Merged
merged 1 commit into from
Dec 17, 2021
Merged

fix(material-experimental/mdc-slide-toggle): remove aria-required rather than setting to false #24105

merged 1 commit into from
Dec 17, 2021

Conversation

mmalerba
Copy link
Contributor

Both are equally valid to mark the control as not required, but setting
it to false generates a bunch of false-positive lint errors in google3

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Dec 15, 2021
@mmalerba
fix(material-experimental/mdc-slide-toggle): remove aria-required rat…
df6d289 
…her than setting to false

Both are equally valid to mark the control as not required, but setting
it to false generates a bunch of false-positive lint errors in google3
crisbeto
crisbeto approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 16, 2021
@mmalerba mmalerba merged commit 2cc0640 into angular:master Dec 17, 2021
mmalerba added a commit that referenced this pull request Dec 17, 2021
@mmalerba
fix(material-experimental/mdc-slide-toggle): remove aria-required rat…
997589d 
…her than setting to false (#24105)

Both are equally valid to mark the control as not required, but setting
it to false generates a bunch of false-positive lint errors in google3

(cherry picked from commit 2cc0640)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmalerba @crisbeto