fix(material/stepper): assistive technology reading out stepper icon #24025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
amysorto
reviewed
Nov 29, 2021
| <div | ||
| class="mat-step-icon-state-{{state}} mat-step-icon" | ||
| [class.mat-step-icon-selected]="selected" | ||
| aria-hidden="true"> |
There was a problem hiding this comment.
Lines 16 and 17 (the completed and editable labels) need to be pulled out of this div so it can be read aloud by screenreaders.
Fixes that the text inside the icon was being read out when the user interacts with the stepper header using assistive technology.
crisbeto
force-pushed
the
stepper-icon-hidden
branch
from
d0b5e04
to
42cce33
Compare
This was referenced Jan 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the text inside the icon was being read out when the user interacts with the stepper header using assistive technology.