Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): update to angular v13.0.1 to emit proper partial compilation output #23951

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 11, 2021

Updates to Angular v13.0.1 which fixes the partial compilation output
for forwardRef usages in queries. The fixed partial compilation output
will ensure that Angular CDK/Material works with JIT linking at runtime,
as done in e.g. Jest.

Fix upstream in framework: angular/angular#44113.

We will add some testing for the JIT linker to the angular/components
repository with: #23882. That should help ensuring JIT linking does
not regress.

Fixes #23907.

…lation output

Updates to Angular v13.0.1 which fixes the partial compilation output
for `forwardRef` usages in queries. The fixed partial compilation output
will ensure that Angular CDK/Material works with JIT linking at runtime,
as done in e.g. Jest.

Fix upstream: angular/angular#44113.

We will add some testing for the JIT linker to the `angular/components`
repository with: angular#23882. That
should help ensuring JIT linking does not regress.

Fixes angular#23907.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2021
@devversion
Copy link
Member Author

devversion commented Nov 11, 2021

I'm misusing the multiple scope here so that I can land this commit as a fix to appear in the changelog. Most likely in the future we should have another scope like package-output. Some build changes are actually relevant for consumers of the library.

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Nov 11, 2021
@devversion devversion marked this pull request as ready for review November 11, 2021 14:44
@devversion devversion requested a review from a team as a code owner November 11, 2021 14:44
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 11, 2021
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto merged commit 8cb0f12 into angular:master Nov 11, 2021
amysorto pushed a commit that referenced this pull request Nov 11, 2021
…lation output (#23951)

Updates to Angular v13.0.1 which fixes the partial compilation output
for `forwardRef` usages in queries. The fixed partial compilation output
will ensure that Angular CDK/Material works with JIT linking at runtime,
as done in e.g. Jest.

Fix upstream: angular/angular#44113.

We will add some testing for the JIT linker to the `angular/components`
repository with: #23882. That
should help ensuring JIT linking does not regress.

Fixes #23907.

(cherry picked from commit 8cb0f12)
@LPCmedia
Copy link

so is this released or not ? We are still seing this error in 13.0.2 for our own components.

@michaelfaith
Copy link

We stopped having issues with this release and the compiler 13.0.1 release. Did you also update your @angular/compiler dependency and rebuild your library?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
5 participants