Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): hover styles not disabled on touch devices #23915

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 7, 2021

When we introduced the date range picker, some selectors in the calendar became much more specific which ended up overriding the styles that disable the hover indication on touch devices.

Now that we don't need to worry about IE, these changes use the hover media query to enable hovering only on non-touch devices instead.

Fixes #23904.

When we introduced the date range picker, some selectors in the calendar became much more specific which ended up overriding the styles that disable the hover indication on touch devices.

Now that we don't need to worry about IE, these changes use the `hover` media query to enable hovering only on non-touch devices instead.

Fixes angular#23904.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 7, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2021
@crisbeto crisbeto added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 7, 2021
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

@crisbeto crisbeto removed the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 7, 2021
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 106b8a7 into angular:master Dec 3, 2021
wagnermaciel pushed a commit that referenced this pull request Dec 3, 2021
…23915)

When we introduced the date range picker, some selectors in the calendar became much more specific which ended up overriding the styles that disable the hover indication on touch devices.

Now that we don't need to worry about IE, these changes use the `hover` media query to enable hovering only on non-touch devices instead.

Fixes #23904.

(cherry picked from commit 106b8a7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-datepicker): IOS: Incorrect hover display after year selection
3 participants