-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk/bidi): support auto
direction value
#23906
Conversation
af532df
to
090656e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a brief paragraph in the docs that explains how we handle "auto"
?
Adds support for the `auto` value of the `dir` attribute. The value gets resolved to `ltr` or `rtl` based on browser's locale. Fixes angular#10186.
090656e
to
d555ff4
Compare
The feedback has been addressed. |
nice work <3 @crisbeto crisbeto |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds support for the
auto
value of thedir
attribute. The value gets resolved toltr
orrtl
based on browser's locale.Fixes #10186.
Note: I didn't include a test, because mocking
navigator.language
is difficult.