Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/form-field): update outline gap when prefix changes #23869

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(material/form-field): update outline gap when prefix changes #23869

merged 1 commit into from
Nov 8, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 2, 2021

The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes #23863.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 2, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2021
@crisbeto crisbeto mentioned this pull request Nov 2, 2021
Closed
@crisbeto
Copy link
Member Author

crisbeto commented Nov 2, 2021

Browserstack failure will be resolved by #23870.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2021
@crisbeto
fix(material/form-field): update outline gap when prefix changes
a460856 
The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes angular#23863.
@crisbeto crisbeto force-pushed the 23863/form-field-prefix-change branch from 93a8d48 to a460856 Compare November 2, 2021 17:30
@amysorto amysorto merged commit a6d4141 into angular:master Nov 8, 2021
amysorto pushed a commit that referenced this pull request Nov 8, 2021
@crisbeto @amysorto
fix(material/form-field): update outline gap when prefix changes (#23869
5d49df1 
)

The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes #23863.

(cherry picked from commit a6d4141)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-form-field): label is not within the border gap for outline appearance
3 participants
@crisbeto @devversion @amysorto