Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): Declare that MatChipInput.inputElement is always defined #23868

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(material/chips): Declare that MatChipInput.inputElement is always defined #23868

merged 1 commit into from
Nov 8, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 1, 2021

It is initialized in the constructor, so there is no chance of it being
undefined.

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Nov 1, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2021
crisbeto
crisbeto approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 1, 2021
@crisbeto
Copy link
Member

crisbeto commented Nov 2, 2021

Browserstack failure will be resolved by #23870.

@mmalerba
fix(material/chips): Declare that MatChipInput.inputElement is always…
42224fb 
… defined

It is initialized in the contructor, so there is no chance of it being
undefined.
@amysorto amysorto merged commit 72d2e5a into angular:master Nov 8, 2021
amysorto pushed a commit that referenced this pull request Nov 8, 2021
@mmalerba @amysorto
fix(material/chips): Declare that MatChipInput.inputElement is always…
e8a6eed 
… defined (#23868)

It is initialized in the contructor, so there is no chance of it being
undefined.

(cherry picked from commit 72d2e5a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmalerba @crisbeto @jelbourn @amysorto