-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/chips): add selected indication in high contrast mode #23828
Conversation
Currently the single-selection chip shows that it's selected by changing its background color, but that doesn't work in high contrast mode. These changes add a thicker outline when the chip is selected.
@@ -50,6 +50,7 @@ export class MatChipSelectionChange { | |||
'[class.mat-mdc-chip-with-avatar]': 'leadingIcon', | |||
'[class.mat-mdc-chip-with-trailing-icon]': 'trailingIcon || removeIcon', | |||
'[class.mat-mdc-chip-selected]': 'selected', | |||
'[class.mat-mdc-chip-multiple]': '_chipListMultiple', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've rather renamed the mat-mdc-chip-selected
since there are no usages of it in our codebase, but there are some in g3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the single-selection chip shows that it's selected by changing its background color, but that doesn't work in high contrast mode. These changes add a thicker outline when the chip is selected.