fix(material/input): incorrect color for select using the size attribute #23734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't apply the theme colors to native `select` elements, because it can the option text to blend in with the background for Windows users. Our current approach seems to break down for inline selects (with `multiple` or `size` attributes), because they don't have a dropdown, but are instead rendered inline. These changes make it so the exclusion is only applied to `select` elements that have a dropdown.
crisbeto
added
P2
crisbeto
requested review from
devversion,
mmalerba and
a team
as code owners
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
Oct 12, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Oct 19, 2021
…ute (#23734) Currently we don't apply the theme colors to native `select` elements, because it can the option text to blend in with the background for Windows users. Our current approach seems to break down for inline selects (with `multiple` or `size` attributes), because they don't have a dropdown, but are instead rendered inline. These changes make it so the exclusion is only applied to `select` elements that have a dropdown. (cherry picked from commit 032cb06)
andrewseguin
pushed a commit
that referenced
this pull request
Oct 19, 2021
…ute (#23734) Currently we don't apply the theme colors to native `select` elements, because it can the option text to blend in with the background for Windows users. Our current approach seems to break down for inline selects (with `multiple` or `size` attributes), because they don't have a dropdown, but are instead rendered inline. These changes make it so the exclusion is only applied to `select` elements that have a dropdown. (cherry picked from commit 032cb06)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Oct 22, 2021
…ute (angular#23734) Currently we don't apply the theme colors to native `select` elements, because it can the option text to blend in with the background for Windows users. Our current approach seems to break down for inline selects (with `multiple` or `size` attributes), because they don't have a dropdown, but are instead rendered inline. These changes make it so the exclusion is only applied to `select` elements that have a dropdown.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't apply the theme colors to native
selectelements, because it can the option text to blend in with the background for Windows users. Our current approach seems to break down for inline selects (withmultipleorsizeattributes), because they don't have a dropdown, but are instead rendered inline.These changes make it so the exclusion is only applied to
selectelements that have a dropdown.