fix(cdk/overlay): OverlayRef.outsidePointerEvents() should only emit … #23679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
added
merge: caretaker note
|
Caretaker note: these changes have the potential of breaking tests. We should trigger an exploratory presubmit to get a feel for how breaking it will be. |
|
I refactored the PR according to the discussion in #23643. The breaking change has been removed and the PR description updated. The following scenarios are now covered:
I'm open to suggestions for improvement. |
crisbeto
approved these changes
Oct 10, 2021
…due to pointerdown outside overlay Currently OverlayRef.outsidePointerEvents() emits when a user starts a click inside the overlay, drags the cursor outside the overlay and releases the click (e.g. selecting text and moving the mouse outside the overlay). In order to only emit when the click originates outside the overlay, we track the target of the preceding pointerdown event and check if it originated from outside the overlay. Fixes #23643
|
Is there a chance of this landing in v13? |
|
I can't guarantee when it'll land since it has to follow the process for merging pull requests. |
andrewseguin
pushed a commit
that referenced
this pull request
Oct 19, 2021
…due to pointerdown outside overlay (#23679) Currently OverlayRef.outsidePointerEvents() emits when a user starts a click inside the overlay, drags the cursor outside the overlay and releases the click (e.g. selecting text and moving the mouse outside the overlay). In order to only emit when the click originates outside the overlay, we track the target of the preceding pointerdown event and check if it originated from outside the overlay. Fixes #23643 (cherry picked from commit 335a798)
andrewseguin
pushed a commit
that referenced
this pull request
Oct 19, 2021
…due to pointerdown outside overlay (#23679) Currently OverlayRef.outsidePointerEvents() emits when a user starts a click inside the overlay, drags the cursor outside the overlay and releases the click (e.g. selecting text and moving the mouse outside the overlay). In order to only emit when the click originates outside the overlay, we track the target of the preceding pointerdown event and check if it originated from outside the overlay. Fixes #23643 (cherry picked from commit 335a798)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Oct 22, 2021
…due to pointerdown outside overlay (angular#23679) Currently OverlayRef.outsidePointerEvents() emits when a user starts a click inside the overlay, drags the cursor outside the overlay and releases the click (e.g. selecting text and moving the mouse outside the overlay). In order to only emit when the click originates outside the overlay, we track the target of the preceding pointerdown event and check if it originated from outside the overlay. Fixes angular#23643
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…due to pointerdown outside overlay
Currently OverlayRef.outsidePointerEvents() emits when a user starts a click inside the overlay,
drags the cursor outside the overlay and releases the click (e.g. selecting text and moving the
mouse outside the overlay). In order to only emit when the click originates outside the overlay,
we track the target of the preceding pointerdown event and check if it originated from outside
the overlay.
Fixes #23643