fix(material-date-fns-adapter): locale not passed into parse function #23653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the locale wasn't being passed into the parsing function of `date-fns`. Fixes angular#23652.
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
commented
Sep 28, 2021
| @@ -54,7 +54,7 @@ const DAY_OF_WEEK_FORMATS = { | |||
| export class DateFnsAdapter extends DateAdapter<Date, Locale> { | |||
| constructor(@Optional() @Inject(MAT_DATE_LOCALE) matDateLocale: {}) { | |||
| super(); | |||
| super.setLocale(matDateLocale); | |||
| this.setLocale(matDateLocale); | |||
There was a problem hiding this comment.
This change isn't part of the fix, but I figured that it's less error-prone if we were to add a setLocale override.
jelbourn
added
action: merge
zarend
added
target: rc
|
I could not merge this into patch due to merge conflicts with |
zarend
pushed a commit
that referenced
this pull request
Oct 12, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the locale wasn't being passed into the parsing function of
date-fns.Fixes #23652.