Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/select): trim aria-labelledby #22251

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(material/select): trim aria-labelledby #22251

merged 1 commit into from
Mar 19, 2021

Conversation

crisbeto
Copy link
Member

If the form field doesn't have a label, we can end up with an aria-labelledby which has a leading space. This appears to be flagged as invalid by some a11y tools.

Fixes #22192.

@crisbeto
fix(material/select): trim aria-labelledby
fc88abc 
If the form field doesn't have a label, we can end up with an `aria-labelledby` which has a leading
space. This appears to be flagged as invalid by some a11y tools.

Fixes angular#22192.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Mar 16, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 16, 2021
jelbourn
jelbourn approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 16, 2021
@andrewseguin andrewseguin merged commit 9b67d67 into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto @andrewseguin
fix(material/select): trim aria-labelledby (#22251)
cdbf876 
If the form field doesn't have a label, we can end up with an `aria-labelledby` which has a leading
space. This appears to be flagged as invalid by some a11y tools.

Fixes #22192.

(cherry picked from commit 9b67d67)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @jelbourn @andrewseguin