fix(material/table): data source filteredData not updating while disconnected #22058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnected The data source was changed in angular#21338 so that it unsubscribes while it's disconnected. The problem is that the subscription has a side effect which updates `filteredData` as well. These changes add some logic so that `filteredData` is updated even if the source is disconnected. Fixes angular#21984.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
Mar 5, 2021
annieyw
pushed a commit
that referenced
this pull request
Mar 9, 2021
…onnected (#22058) The data source was changed in #21338 so that it unsubscribes while it's disconnected. The problem is that the subscription has a side effect which updates `filteredData` as well. These changes add some logic so that `filteredData` is updated even if the source is disconnected. Fixes #21984. (cherry picked from commit 0093105)
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data source was changed in #21338 so that it unsubscribes while it's disconnected. The problem is that the subscription has a side effect which updates
filteredDataas well.These changes add some logic so that
filteredDatais updated even if the source is disconnected.Fixes #21984.