Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/schematics): generate code that works in strict CLI projects #22052

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

Splaktar
Copy link
Member

  • fix strictNullChecks errors
  • fix strictPropertyInitialization errors
  • default to smaller paginator rows so that paging works out of the box
  • fix tslint errors from default CLI settings

Fixes #21981

@Splaktar Splaktar self-assigned this Feb 28, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 28, 2021
@Splaktar Splaktar added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release area: ng-generate Schematics that generate code in user projects labels Feb 28, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ects

- fix `strictNullChecks` errors
- fix `strictPropertyInitialization` errors
- default to smaller paginator rows so that paging works out of the box
- fix tslint errors from default CLI settings

Fixes angular#21981
- fix tslint error from default CLI settings

Relates to angular#21981
@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@annieyw annieyw merged commit 0441ae9 into angular:master Mar 5, 2021
annieyw pushed a commit that referenced this pull request Mar 5, 2021
…ects (#22052)

* fix(material/schematics): generate code that works in strict CLI projects

- fix `strictNullChecks` errors
- fix `strictPropertyInitialization` errors
- default to smaller paginator rows so that paging works out of the box
- fix tslint errors from default CLI settings

Fixes #21981

* fix(cdk/schematics): generate code that works in strict CLI projects

- fix tslint error from default CLI settings

Relates to #21981

(cherry picked from commit 0441ae9)
@Splaktar Splaktar deleted the schematic-strictness branch March 5, 2021 04:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: ng-generate Schematics that generate code in user projects cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/schematics): table schematic does not generate code that works with strict mode
3 participants