Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/drag-drop): allow for preview container to be customized #21830

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2021

Currently we always insert the drag preview at the body, because it allows us to avoid dealing with overflow and z-index. The problem is that it doesn't allow the preview to retain its inherited styles.

These changes add a new input which allows the consumer to configure the place into which the preview will be inserted.

Fixes #13288.

Currently we always insert the drag preview at the `body`, because it allows us to avoid
dealing with `overflow` and `z-index`. The problem is that it doesn't allow the preview to
retain its inherited styles.

These changes add a new input which allows the consumer to configure the place into
which the preview will be inserted.

Fixes angular#13288.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Feb 7, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM<

@@ -43,4 +43,5 @@ export interface DragDropConfig extends Partial<DragRefConfig> {
listAutoScrollDisabled?: boolean;
listOrientation?: DropListOrientation;
zIndex?: number;
previewContainer?: 'global' | 'parent';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this option type PreviewContainer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the interface for the global config object. It didn't seem like an HTMLElement would make sense there, given that it's configured before the app is initialized.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(drag-drop): moved item doesn't retain inherited styles
3 participants