Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: max-line-length check not catching all cases #17570

Merged
merged 1 commit into from Nov 1, 2019
Merged

build: max-line-length check not catching all cases #17570

merged 1 commit into from Nov 1, 2019

Commits on Nov 1, 2019

  1. build: max-line-length check not catching all cases 

    In tslint 5.19.0 they added a separate option that determines whether strings should be checked and it seems to have been defaulted to `false` (palantir/tslint#4798). As a result we ended up with a few places where the limit was being violated.

These changes explicitly enable checking of strings and fix the failures that we had accumulated.
    @crisbeto
    crisbeto committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    0a124cc View commit details
    Browse the repository at this point in the history