Skip to content

Commit

Permalink
fix(material/slider): avoid manual fixing values on pointer up (#26215)
Browse files Browse the repository at this point in the history
* fix(material/slider): avoid manual fixing values on pointer up

* Fixes issue #26172

* fixup! fix(material/slider): avoid manual fixing values on pointer up

* fixup! fix(material/slider): avoid manual fixing values on pointer up

* fixup! fix(material/slider): avoid manual fixing values on pointer up

(cherry picked from commit 3998906)
  • Loading branch information
wagnermaciel committed Dec 13, 2022
1 parent 1e93df3 commit fee5d0b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
19 changes: 10 additions & 9 deletions src/material/slider/slider-input.ts
Expand Up @@ -439,12 +439,11 @@ export class MatSliderThumb implements _MatSliderThumb, OnDestroy, ControlValueA
}
}

_onPointerUp(event: PointerEvent): void {
_onPointerUp(): void {
this._isActive = false;
this._updateWidthInactive();
if (!this.disabled) {
this._handleValueCorrection(event);
}
setTimeout(() => {
this._updateWidthInactive();
});
}

_clamp(v: number): number {
Expand Down Expand Up @@ -636,11 +635,13 @@ export class MatSliderRangeThumb extends MatSliderThumb implements _MatSliderRan
super._onPointerDown(event);
}

override _onPointerUp(event: PointerEvent): void {
super._onPointerUp(event);
override _onPointerUp(): void {
super._onPointerUp();
if (this._sibling) {
this._sibling._updateWidthInactive();
this._sibling._hostElement.classList.remove('mat-mdc-slider-input-no-pointer-events');
setTimeout(() => {
this._sibling!._updateWidthInactive();
this._sibling!._hostElement.classList.remove('mat-mdc-slider-input-no-pointer-events');
});
}
}

Expand Down
4 changes: 2 additions & 2 deletions tools/public_api_guard/material/slider.md
Expand Up @@ -167,7 +167,7 @@ export class MatSliderRangeThumb extends MatSliderThumb implements _MatSliderRan
// (undocumented)
_onPointerMove(event: PointerEvent): void;
// (undocumented)
_onPointerUp(event: PointerEvent): void;
_onPointerUp(): void;
// (undocumented)
_setIsLeftThumb(): void;
// (undocumented)
Expand Down Expand Up @@ -243,7 +243,7 @@ export class MatSliderThumb implements _MatSliderThumb, OnDestroy, ControlValueA
// (undocumented)
_onPointerMove(event: PointerEvent): void;
// (undocumented)
_onPointerUp(event: PointerEvent): void;
_onPointerUp(): void;
get percentage(): number;
registerOnChange(fn: any): void;
registerOnTouched(fn: any): void;
Expand Down

0 comments on commit fee5d0b

Please sign in to comment.