Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): preserve existing properties in HttpClientModule migration #55777

Closed
wants to merge 1 commit into from
Closed

fix(migrations): preserve existing properties in HttpClientModule migration #55777

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The HttpClientModule migration was dropping the existing properties other than imports and providers when updating an @NgModule, @Component or configureTestingModule.

What is the new behavior?

The other properties are now preserved

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat
fix(migrations): preserve existing properties in HttpClientModule mig…
9663cc1 
…ration

The `HttpClientModule` migration was dropping the existing properties other than imports and providers when updating an `@NgModule`, `@Component` or `configureTestingModule`.
@cexbrayat cexbrayat requested a review from crisbeto May 13, 2024 14:58
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate labels May 14, 2024
@ngbot ngbot bot modified the milestone: Backlog May 14, 2024
@crisbeto crisbeto modified the milestones: Backlog, v18 final May 14, 2024
@atscott
Copy link
Contributor

atscott commented May 14, 2024

This PR was merged into the repository by commit ccde17d.

@atscott atscott closed this in ccde17d May 14, 2024
atscott pushed a commit that referenced this pull request May 14, 2024
@cexbrayat @atscott
fix(migrations): preserve existing properties in HttpClientModule mig…
bb4a401 
…ration (#55777)

The `HttpClientModule` migration was dropping the existing properties other than imports and providers when updating an `@NgModule`, `@Component` or `configureTestingModule`.

PR Close #55777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v18 final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cexbrayat @atscott @crisbeto