fix(core): add warning when using zoneless but zone.js is still loaded #55769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
JeanMeche
reviewed
May 13, 2024
pkozlowski-opensource
requested changes
May 13, 2024
There was a problem hiding this comment.
LGTM (with one nit comment) but as @JeanMeche noted the negative error code suggest that there are docs for this error, while docs are not part of this PR. Either add docs or flip the negative sign on the error code.
crisbeto
force-pushed
the
zoneless-warning
branch
from
6faed77
to
9c5be5a
Compare
|
I've switched it to a positive error code. |
JeanMeche
approved these changes
May 13, 2024
atscott
approved these changes
May 14, 2024
pkozlowski-opensource
approved these changes
May 14, 2024
packages/core/src/change_detection/scheduling/zoneless_scheduling_impl.ts
Outdated
Show resolved
Hide resolved
packages/core/src/change_detection/scheduling/zoneless_scheduling_impl.ts
Outdated
Show resolved
Hide resolved
packages/core/src/change_detection/scheduling/zoneless_scheduling_impl.ts
Show resolved
Hide resolved
crisbeto
force-pushed
the
zoneless-warning
branch
from
9c5be5a
to
d0ef1ee
Compare
AndrewKushnir
approved these changes
May 15, 2024
AndrewKushnir
approved these changes
May 15, 2024
atscott
approved these changes
May 15, 2024
atscott
added
action: merge
Users may be using zoneless, but are still loading Zone.js in which case they won't get the full benefits like reduced bundle size. These changes detect such a case and log a warning.
crisbeto
force-pushed
the
zoneless-warning
branch
from
d0ef1ee
to
9d87582
Compare
thePunderWoman
approved these changes
May 15, 2024
|
This PR was merged into the repository by commit ae0baa2. |
|
Just FYI, @angular/fire does not work without Zones, so the only way to use that with zoneless, is to still load zoneJS in polyfills, but use the zoneless change detection. Removal of zoneJS from polyfills will lead to @angular/fire crashing out badly. So for a while , until they get that fixed (if they do), this will give a warning for a lot of people trying out zoneless with @angular/fire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may be using zoneless, but are still loading Zone.js in which case they won't get the full benefits like reduced bundle size. These changes detect such a case and log a warning.