Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix visible code snippets in first-app tutorial #55742

Closed
wants to merge 1 commit into from
Closed

docs: fix visible code snippets in first-app tutorial #55742

wants to merge 1 commit into from

Conversation

bencodezen
Copy link
Contributor

@bencodezen bencodezen commented May 8, 2024 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The code snippets in the first app tutorial were displaying the wrong sections. This is most likely due to prettier or some type of formatting change.

Issue Number: Related to #55725

What is the new behavior?

New code snippets should appear as expected in regards to relevancy to the instructions provided.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 8, 2024
@bencodezen bencodezen added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 8, 2024
@ngbot ngbot bot added this to the Backlog milestone May 8, 2024
@bencodezen bencodezen added area: adev Angular.dev documentation adev: preview target: patch This PR is targeted for the next patch release labels May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deployed adev-preview for 427d2b2 to: https://ng-dev-previews-fw--pr-angular-angular-55742-adev-prev-4se6ixlb.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

JeanMeche
JeanMeche approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 8, 2024
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2024
@atscott
Copy link
Contributor

atscott commented May 8, 2024

This PR was merged into the repository by commit c1915f1.

@atscott atscott closed this in c1915f1 May 8, 2024
atscott pushed a commit that referenced this pull request May 8, 2024
@bencodezen @atscott
docs: fix visible code snippets in first-app tutorial (#55742)
28a24b6 
PR Close #55742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott atscott approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bencodezen @atscott @JeanMeche @devversion