[Path port] fix(compiler): add math elements to schema #55645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
changed the title
pullapprove
bot
requested review from
alxhub,
jelbourn,
josephperrott and
pkozlowski-opensource
AndrewKushnir
previously approved these changes
May 2, 2024
|
Disabling PullApprove since this is just a cherry-pick of #55631 which was reviewed already. |
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags. Fixes angular#55608. PR Close angular#55631
crisbeto
added
action: merge
crisbeto
removed request for
jelbourn,
pkozlowski-opensource,
alxhub and
josephperrott
AndrewKushnir
approved these changes
May 2, 2024
|
This PR was merged into the repository by commit c21b459. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2024
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags. Fixes #55608. PR Close #55631 PR Close #55645
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a patch port of the changes from #55631.
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are
MathMLElementrather than something likeSVGCircleElement. As such, I ended up having to hardcode the currently-available tags.Fixes #55608.