docs(docs-infra): move back all xterm code to the fw repo #55642
+139
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
approved these changes
May 13, 2024
package.json
Outdated
| @@ -183,6 +184,7 @@ | |||
| "@types/inquirer": "^9.0.3", | |||
| "@types/jsdom": "^21.1.5", | |||
| "@typescript/vfs": "^1.5.0", | |||
| "@xterm/xterm": "^5.4.0", | |||
There was a problem hiding this comment.
Is there a reason the other dependency is in dependencies and this not?
adev/angular.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "tsConfig": "tsconfig.app.json", | |||
| "inlineStyleLanguage": "scss", | |||
| "assets": ["src/favicon.ico", "src/robots.txt", "src/assets"], | |||
| "styles": ["@angular/docs/styles/global-styles.scss"], | |||
| "styles": ["@angular/docs/styles/global-styles.scss", ".src/local-styles.scss"], | |||
Previously, the `@angular/docs` package had `xterm` as dependency but wasn't referencing it. It only had dedicated styles. This commit moves back the styles to the FW repo as it is only used here.
|
Deployed adev-preview for b5026f6 to: https://ng-dev-previews-fw--pr-angular-angular-55642-adev-prev-glleris6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
@angular/docspackage hadxtermas dependency but wasn't referencing it. It only had dedicated styles. This commit moves back the styles to the FW repo as it is only used here.