Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): Add update guide to adev #55638

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 2, 2024

Migrating the code we had in the https://github.com/angular/angular-update-guide repo.

Only minor changes were introduced : control-flow migration and replaced showdown usages with marked that we already used on adev.

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 2, 2024
@ngbot ngbot bot added this to the Backlog milestone May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Deployed adev-preview for bb68a4f to: https://ng-dev-previews-fw--pr-angular-angular-55638-adev-prev-0fvar8k6.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@twerske
Copy link
Contributor

twerske commented May 2, 2024

Adding to ADEV is stable milestone- it's not a blocker but it'd mean @josephperrott doesn't need to migrate that DNS and change where we add v18 to.

@mgechev
Copy link
Member

mgechev commented May 2, 2024

That's awesome @JeanMeche, thank you!

@JeanMeche JeanMeche changed the title docs(docs-infra): Add upgrate guide to adev docs(docs-infra): Add update guide to adev May 2, 2024
@JeanMeche JeanMeche force-pushed the docs/update-guide branch 5 times, most recently from ed321e6 to 8f840e7 Compare May 2, 2024 23:14
@JeanMeche JeanMeche force-pushed the docs/update-guide branch 2 times, most recently from d0e7d6e to b708b12 Compare May 2, 2024 23:22
@JeanMeche JeanMeche force-pushed the docs/update-guide branch 2 times, most recently from 1dad8de to ee67df5 Compare May 13, 2024 16:12
@JeanMeche JeanMeche marked this pull request as ready for review May 13, 2024 16:16
@pullapprove pullapprove bot requested a review from devversion May 13, 2024 16:16
@devversion devversion requested review from twerske and removed request for devversion May 15, 2024 07:09
@pullapprove pullapprove bot requested a review from devversion May 15, 2024 07:10
@devversion devversion requested review from josephperrott and removed request for devversion May 15, 2024 07:10
@JeanMeche JeanMeche force-pushed the docs/update-guide branch 2 times, most recently from 86bd02f to 4a4c5ff Compare May 16, 2024 23:21
@twerske twerske added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 21, 2024
@twerske twerske removed the request for review from josephperrott May 21, 2024 18:58
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit 19d782b.

@dylhunn dylhunn closed this in 19d782b May 21, 2024
dylhunn pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants