Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): added @angular/compiler as a peer dependency #55610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emilrowland
Copy link

This fixes an issue with packages managers likes pmpm that will not link the @angular/compiler package to the @angular/core package if it is not listed as a peer dependency.
I added it as optional peer dependency as it's only used in special cases.

Fixes #38096

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Today @angular/core/testing is using @angular/compiler without specifying it as a dependency.
This results in strict package managers like pnpm don't find the dependency.

Issue Number: #38096

What is the new behavior?

@angular/compiler is added as an optional peerDependency for @angular/core

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This fixes an issue with packages managers likes pmpm
that will not link the @angular/compiler package to the @angular/core
package if it is not listed as a peer dependency.
I added it as optional peer dependency as it's only used in special cases.

Fixes angular#38096
Copy link

google-cla bot commented May 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from alxhub May 1, 2024 13:42
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label May 1, 2024
@ngbot ngbot bot added this to the Backlog milestone May 1, 2024
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one NIT.

For context, @angular/compiler is required by @angular/core/testing

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/core/testing imports @angular/compiler without it being a listed dependency
3 participants