Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): private export token to disable fixture.detectChanges error #55098

Closed
wants to merge 1 commit into from

Commits on Mar 28, 2024

  1. refactor(core): private export token to disable `fixture.detectChange…

    …s` error
    
    While we do want to discourage `fixture.detectChanges`, it is yet to be
    determined how this should be accomplished (warning, documentation, etc.). At
    the moment, not being able to disable the error at all is entirely
    prohibitive for existing test suites to use zoneless change detection in
    tests. We would much rather allow existing test suites to disable the
    error and use the zoneless change detection than prevent them from using
    it entirely until all the `detectChanges` calls have been fixed.
    Calling `detectChanges` manually can hide errors related to change
    detection timing, but it is even worse when the "PseudoApplication"
    fixture used (since it runs change detection _only_ on the component
    rather than through `ApplicationRef`).
    atscott committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bb31a06 View commit details
    Browse the repository at this point in the history