Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): make any injector scope configurable #54907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates an internal logic to treat any as any other scope. Previously, there was a hardcoded exception for any scope specifically.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Mar 15, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 15, 2024
@AndrewKushnir AndrewKushnir force-pushed the injector_any_scope branch 2 times, most recently from 37277df to 2ed0992 Compare March 16, 2024 04:19
@AndrewKushnir
Copy link
Contributor Author

Exploratory presubmit.

This commit updates an internal logic to treat `any` as any other scope. Previously, there was a hardcoded exception for `any` scope specifically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant