Fix devtools iframe backend ready bug #54805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar DevTools' browser code (angular#53934)" (angular#54629)" This reverts commit dd9f9d7.
…evtools page (angular#53934)" (angular#54629)" This reverts commit 133319e.
dgp1130
reviewed
Mar 11, 2024
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
from
ed9f9a2
to
96a3298
Compare
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
2 times, most recently
from
d7ab4e6
to
02471b7
Compare
josephperrott
approved these changes
Mar 12, 2024
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
from
02471b7
to
8cefec5
Compare
dgp1130
reviewed
Mar 12, 2024
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
from
8cefec5
to
d295ae0
Compare
dgp1130
reviewed
Mar 13, 2024
| topLevelContentScriptPort, | ||
| childContentScriptPort, | ||
| devtoolsPort, | ||
| } of eachPermutationOfDevToolsInitializing()) { |
There was a problem hiding this comment.
Consider: We don't strictly need to do this for every test as long as we have reasonable confidence that we're correctly handling all the initialization possibilities. It might be possible to do this only for a subset of tests and still get the same confidence. Up to you which tests that is, or if we really need to do it for all of the tests.
There was a problem hiding this comment.
I thought about this too 🤔 I think it's fine to run this for every test case in this file since we expect this part of the code base to be pretty stable. At worst it does little harm and at best it could catch non-obvious sequencing edge cases in the future. By having it run for all (or most) of the cases in this file we're also conveying that the output state of TabManager should be identical regardless of the ordering of events that it processes
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
3 times, most recently
from
abdd5d9
to
00dc64e
Compare
dgp1130
reviewed
Mar 15, 2024
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
3 times, most recently
from
21e729e
to
3632924
Compare
… not detected error Previously, a race condition could cause DevTools to enter a state where it can't detect an application on reload. This was caused by a sequencing issue between the content script connection, the devtools panel connection and an event "backendReady" that lets DevTools know when a particular frame is ready to be inspected. This commit replaces the previously stored backendReady boolean with a promise, so that the devtools panel can eventually run a callback to connect to a content script when that content script emits it's backendReady message.
AleksanderBodurri
force-pushed
the
fix-devtools-iframe-backend-ready-bug
branch
from
3632924
to
38fa6fa
Compare
dgp1130
approved these changes
Mar 26, 2024
|
This PR was merged into the repository by commit d15dca0. |
dylhunn
pushed a commit
that referenced
this pull request
Mar 26, 2024
dylhunn
pushed a commit
that referenced
this pull request
Mar 26, 2024
dylhunn
pushed a commit
that referenced
this pull request
Mar 26, 2024
… not detected error (#54805) Previously, a race condition could cause DevTools to enter a state where it can't detect an application on reload. This was caused by a sequencing issue between the content script connection, the devtools panel connection and an event "backendReady" that lets DevTools know when a particular frame is ready to be inspected. This commit replaces the previously stored backendReady boolean with a promise, so that the devtools panel can eventually run a callback to connect to a content script when that content script emits it's backendReady message. PR Close #54805
dylhunn
pushed a commit
that referenced
this pull request
Mar 26, 2024
dylhunn
pushed a commit
that referenced
this pull request
Mar 26, 2024
… not detected error (#54805) Previously, a race condition could cause DevTools to enter a state where it can't detect an application on reload. This was caused by a sequencing issue between the content script connection, the devtools panel connection and an event "backendReady" that lets DevTools know when a particular frame is ready to be inspected. This commit replaces the previously stored backendReady boolean with a promise, so that the devtools panel can eventually run a callback to connect to a content script when that content script emits it's backendReady message. PR Close #54805
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…lar DevTools' browser code (angular#53934)" (angular#54629)" (angular#54805) This reverts commit dd9f9d7. PR Close angular#54805
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…evtools page (angular#53934)" (angular#54629)" (angular#54805) This reverts commit 133319e. PR Close angular#54805
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
… not detected error (angular#54805) Previously, a race condition could cause DevTools to enter a state where it can't detect an application on reload. This was caused by a sequencing issue between the content script connection, the devtools panel connection and an event "backendReady" that lets DevTools know when a particular frame is ready to be inspected. This commit replaces the previously stored backendReady boolean with a promise, so that the devtools panel can eventually run a callback to connect to a content script when that content script emits it's backendReady message. PR Close angular#54805
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a race condition could cause DevTools to enter a state where it could not detect an application after a reload. This was caused by a sequencing issue between the content script connection, the devtools panel connection and an event "backendReady" that lets DevTools know when a particular frame is ready to be inspected.
Two commits that caused this behaviour were reverted, along with the features they implemented.
These two commits have been re-reverted, and one new commit has been introduced fixing the issue. This new commit replaces the previously stored backendReady boolean with a promise, so that the devtools panel can eventually run a callback to connect to a content script when that content script emits it's backendReady message.
Related #53953