-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): Update Location
to get a normalized URL valid in case a represented URL starts with the substring equals APP_BASE_HREF
#48489
Conversation
G3 test failures are unrelated, but we'll need a TGP to be safe. |
@atscott could you check the PR? |
…a represented URL starts with the substring equals `APP_BASE_HREF` ```ts @NgModule({ imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])], providers: [{provide: APP_BASE_HREF, useValue: '/en'}] }) export class AppModule {} ``` Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects Fixes: angular#45744
2cf4f5d
to
5c3e4d6
Compare
TGP came back green. Running 1 more sanity check after the rebase. |
This PR was merged into the repository by commit 8802b4a. |
…a represented URL starts with the substring equals `APP_BASE_HREF` (#48489) ```ts @NgModule({ imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])], providers: [{provide: APP_BASE_HREF, useValue: '/en'}] }) export class AppModule {} ``` Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects Fixes: #45744 PR Close #48489
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.0/15.1.1) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.0/15.1.1) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.0/15.1.1) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.0/15.1.1) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.0/15.1.1) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.0/15.1.1) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.0/15.1.1) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.0/15.1.1) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1511-2023-01-18) [Compare Source](angular/angular@15.1.0...15.1.1) ##### common | Commit | Type | Description | | -- | -- | -- | | [68ce4f6ab4](angular/angular@68ce4f6) | fix | Update `Location` to get a normalized URL valid in case a represented URL starts with the substring equals `APP_BASE_HREF` ([#​48489](angular/angular#48489)) | | [032b2bd689](angular/angular@032b2bd) | perf | avoid excessive DOM mutation in NgClass ([#​48433](angular/angular#48433)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [dd54f6bd96](angular/angular@dd54f6b) | fix | makeEnvironmentProviders should accept EnvironmentProviders ([#​48720](angular/angular#48720)) | #### Special Thanks Alan Agius, Alex Rickabaugh, Andrew Scott, Aristeidis Bampakos, Bob Watson, Jens, Konstantin Kharitonov, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Pawel Kozlowski, Vladyslav Slipchenko, ced, dario-piotrowicz, mgechev and ノウラ <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS41In0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1739 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
…a represented URL starts with the substring equals `APP_BASE_HREF` (angular#48489) ```ts @NgModule({ imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])], providers: [{provide: APP_BASE_HREF, useValue: '/en'}] }) export class AppModule {} ``` Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects Fixes: angular#45744 PR Close angular#48489
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fix(common): Update
Location
to get a normalized URL valid in case a represented URL starts with the substring equalsAPP_BASE_HREF
Navigating to
/enigma
will redirect to/en/igma
not to/en/enigma
as it expectsFixes: #45744
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 45744
Does this PR introduce a breaking change?