fix(common): Fix TestBed.overrideProvider type to include multi #48424

atscott · 2022-12-09T20:05:50Z

TestBed.overrideProvider should include multi support in its type. The underlying implementation already supports it, as documented by the tests which are currently casting the override to any to get around the bad type.

AndrewKushnir

LGTM 👍

(the golden file needs to be updated as well)

AndrewKushnir

Reviewed-for: public-api

TestBed.overrideProvider should include `multi` support in its type. The underlying implementation already supports it, as documented by the tests which are currently casting the override to `any` to get around the bad type.

jessicajaniuk

reviewed-for: public-api

atscott · 2022-12-12T17:36:53Z

caretaker note: This is a type-only update. Failing tests are unrelated.

jessicajaniuk · 2022-12-12T17:40:26Z

This PR was merged into the repository by commit e362214.

TestBed.overrideProvider should include `multi` support in its type. The underlying implementation already supports it, as documented by the tests which are currently casting the override to `any` to get around the bad type. PR Close #48424

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.0.2/15.0.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.0.2/15.0.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.0.2/15.0.4) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.0.2/15.0.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.0.2/15.0.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.0.2/15.0.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.0.2/15.0.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.0.2/15.0.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1504-2022-12-14) [Compare Source](angular/angular@15.0.3...15.0.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [6c1064c72f](angular/angular@6c1064c) | fix | fix incorrect handling of camel-case css properties ([#48436](angular/angular#48436)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [f30d18a942](angular/angular@f30d18a) | fix | Fix TestBed.overrideProvider type to include multi ([#48424](angular/angular#48424)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [b55d2dab5d](angular/angular@b55d2da) | fix | evaluate const tuple types statically ([#48091](angular/angular#48091)) | #### Special Thanks Alan Agius, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, BrowserPerson, Jens, Jessica Janiuk, Joey Perrott, JoostK, Konstantin Kharitonov, Lukas Matta, Piotr Kowalski, Virginia Dooley, Yannick Baron, dario-piotrowicz, lsst25, piyush132000 and why520crazy  ### [`v15.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1503-2022-12-07) [Compare Source](angular/angular@15.0.2...15.0.3) ##### common | Commit | Type | Description | | -- | -- | -- | | [50b1c2bf52](angular/angular@50b1c2b) | fix | Don't generate srcsets with very large sources ([#47997](angular/angular#47997)) | | [bf44dc234a](angular/angular@bf44dc2) | fix | Update `Location` to support base href containing `origin` ([#48327](angular/angular#48327)) | ##### compiler | Commit | Type | Description | | -- | -- | -- | | [9a5d84249a](angular/angular@9a5d842) | fix | make sure selectors inside container queries are correctly scoped ([#48353](angular/angular#48353)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [167bc0d163](angular/angular@167bc0d) | fix | Produce diagnostic rather than crash when using invalid hostDirective ([#48314](angular/angular#48314)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [e4dcaa513e](angular/angular@e4dcaa5) | fix | unable to inject ChangeDetectorRef inside host directives ([#48355](angular/angular#48355)) | #### Special Thanks Alan Agius, Alex Castle, Andrew Kushnir, Andrew Scott, Bob Watson, Derek Cormier, Joey Perrott, Konstantin Kharitonov, Kristiyan Kostadinov, Paul Gschwendtner, Pawel Kozlowski, dario-piotrowicz and piyush132000  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1684 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-01-12T16:11:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…lar#48424) TestBed.overrideProvider should include `multi` support in its type. The underlying implementation already supports it, as documented by the tests which are currently casting the override to `any` to get around the bad type. PR Close angular#48424

atscott added the target: patch This PR is targeted for the next patch release label Dec 9, 2022

AndrewKushnir approved these changes Dec 9, 2022

View reviewed changes

atscott force-pushed the multitestbedoverride branch from de1ab8a to cc2593b Compare December 9, 2022 21:30

pullapprove bot requested review from dylhunn, jessicajaniuk and pkozlowski-opensource December 9, 2022 21:30

jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Dec 9, 2022

ngbot bot added this to the Backlog milestone Dec 9, 2022

jessicajaniuk approved these changes Dec 10, 2022

View reviewed changes

jessicajaniuk removed request for pkozlowski-opensource and dylhunn December 10, 2022 00:06

jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Dec 10, 2022

atscott added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Dec 12, 2022

jessicajaniuk closed this in e362214 Dec 12, 2022

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(common): Fix TestBed.overrideProvider type to include multi #48424

fix(common): Fix TestBed.overrideProvider type to include multi #48424

atscott commented Dec 9, 2022

AndrewKushnir left a comment

AndrewKushnir left a comment

jessicajaniuk left a comment

atscott commented Dec 12, 2022

jessicajaniuk commented Dec 12, 2022

angular-automatic-lock-bot bot commented Jan 12, 2023

fix(common): Fix TestBed.overrideProvider type to include multi #48424

fix(common): Fix TestBed.overrideProvider type to include multi #48424

Conversation

atscott commented Dec 9, 2022

AndrewKushnir left a comment

Choose a reason for hiding this comment

AndrewKushnir left a comment

Choose a reason for hiding this comment

jessicajaniuk left a comment

Choose a reason for hiding this comment

atscott commented Dec 12, 2022

jessicajaniuk commented Dec 12, 2022

angular-automatic-lock-bot bot commented Jan 12, 2023