Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): Location does not support base href containing origin #48327

Closed
wants to merge 1 commit into from
Closed

fix(common): Location does not support base href containing origin #48327

wants to merge 1 commit into from

Commits on Dec 6, 2022

  1. fix(common): Update Location to support base href containing origin 

    In case `APP_BASE_HREF` is set including `origin` the further usage of it might cause failure

e.g.
If an app is placed on `https://example.com` and bundles are on `https://cdn-example.com` you have to set `APP_BASE_HREF` up as `https://example.com/` and build the app with `--base-href` as `https://cdn-example.com/` but it does not work because of the bug

Fixes angular#48175
    @constantant
    constantant committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    134d801 View commit details
    Browse the repository at this point in the history