feat(core): support TypeScript 4.9 #48005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
ts-4.9
branch
6 times, most recently
from
34baaab
to
98d9d6f
Compare
crisbeto
commented
Nov 9, 2022
crisbeto
commented
Nov 9, 2022
crisbeto
commented
Nov 9, 2022
| @@ -275,6 +278,78 @@ export const getDecorators: (node: ts.Node) => readonly ts.Decorator[] | undefin | |||
| export const getModifiers: (node: ts.Node) => readonly ts.Modifier[] | undefined = | |||
| IS_AFTER_TS_48 ? (ts as any).getModifiers : node => node.modifiers; | |||
|
|
|||
| /** Type of `ts.factory.CreateParameterDeclaration` in TS 4.9+. */ | |||
There was a problem hiding this comment.
All these backwards-compatible versions are here to avoid deprecation warnings, rather than compilation errors like during the 4.8 update.
crisbeto
added
action: review
pullapprove
bot
requested review from
dylhunn,
JiaLiPassion,
JoostK and
josephperrott
crisbeto
force-pushed
the
ts-4.9
branch
2 times, most recently
from
39acefc
to
0483be5
Compare
crisbeto
commented
Nov 11, 2022
| * TODO(crisbeto): this is a backwards-compatibility layer for versions of TypeScript less than 4.9. | ||
| * We should remove it once we have dropped support for the older versions. | ||
| */ | ||
| function createImportDeclaration( |
There was a problem hiding this comment.
Kind of annoying to have to duplicate this function, but I didn't want the schematics code to do deep imports into the compiler.
JoostK
reviewed
Nov 13, 2022
packages/compiler-cli/ngcc/test/execution/cluster/worker_spec.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/ts_compatibility/src/ts_cross_version_utils.ts
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/ts_compatibility/src/ts_cross_version_utils.ts
Show resolved
Hide resolved
JoostK
approved these changes
Nov 15, 2022
| @@ -98,7 +98,7 @@ | |||
| "@types/jasmine-ajax": "^3.3.1", | |||
| "@types/jasminewd2": "^2.0.8", | |||
| "@types/multimatch": "^4.0.0", | |||
| "@types/node": "^14.15.0", | |||
| "@types/node": "^16.11.7", | |||
There was a problem hiding this comment.
Just noting here that we do still support Node 14, so we'll have to be careful with using the Node 16 types in the repo.
dylhunn
approved these changes
Nov 16, 2022
1 task
1 task
imaksp
reviewed
Dec 2, 2022
Updates to TypeScript 4.9 and resolves some of the errors and deprecation warnings that showed up as a result.
|
Pushed another change to bump to the 4.9 stable version. |
crisbeto
added
action: merge
|
This PR was merged into the repository by commit dd42974. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
Updates to TypeScript 4.9 and resolves some of the errors and deprecation warnings that showed up as a result. PR Close angular#48005
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to TypeScript 4.9 and resolves some of the errors and deprecation warnings that showed up as a result.