Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(platform-browser): resolve memory leak when using animations with shadow DOM #47903

Closed
wants to merge 1 commit into from
Closed

perf(platform-browser): resolve memory leak when using animations with shadow DOM #47903

wants to merge 1 commit into from

Commits on Oct 28, 2022

  1. perf(platform-browser): resolve memory leak when using animations wit… 

    …h shadow DOM

`AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view.

These changes resolve the leak by clearing the reference when the animations renderer is destroyed.

Fixes angular#47892.
    @crisbeto
    crisbeto committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    9ecada4 View commit details
    Browse the repository at this point in the history