Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): make the CommonModule pipes standalone #46401

Closed
wants to merge 1 commit into from
Closed

feat(common): make the CommonModule pipes standalone #46401

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates the pipes presents in the CommonModule and annotates them with the standalone: true flag. With that flag, the pipes can now be imported individually, as well as imported via the CommonModule.

PR Type

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added state: WIP area: common Issues related to APIs in the @angular/common package target: minor This PR is targeted for the next minor release cross-cutting: standalone Issues related to the NgModule-less world labels Jun 17, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 17, 2022
@AndrewKushnir AndrewKushnir force-pushed the common_pipes_standalone branch 3 times, most recently from f374037 to 12e8af1 Compare June 23, 2022 02:22
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jun 23, 2022
@AndrewKushnir AndrewKushnir marked this pull request as ready for review June 23, 2022 02:23
@pullapprove pullapprove bot requested a review from dylhunn June 23, 2022 02:23
@AndrewKushnir
feat(common): make the CommonModule pipes standalone
dc9c472 
This commit updates the pipes presents in the `CommonModule` and annotates them with the `standalone: true` flag. With that flag, the pipes can now be imported individually, as well as imported via the `CommonModule`.
@AndrewKushnir
Copy link
Contributor Author

Exploratory presubmit (TGP).

@AndrewKushnir AndrewKushnir mentioned this pull request Jun 23, 2022
Closed
3 tasks
@pullapprove pullapprove bot requested a review from jessicajaniuk June 23, 2022 08:11
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

alxhub
alxhub approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api, fw-common

@jessicajaniuk jessicajaniuk removed the request for review from dylhunn June 23, 2022 17:47
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jun 23, 2022

This PR was merged into the repository by commit 4a2e733.

@dylhunn dylhunn closed this in 4a2e733 Jun 23, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alxhub alxhub alxhub approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cross-cutting: standalone Issues related to the NgModule-less world target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndrewKushnir @dylhunn @JoostK @pkozlowski-opensource @alxhub @jessicajaniuk