Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): Prevent TSServer from removing templates from … #45965

Closed
wants to merge 1 commit into from
Closed

fix(language-service): Prevent TSServer from removing templates from … #45965

wants to merge 1 commit into from

Commits on May 12, 2022

  1. fix(language-service): Prevent TSServer from removing templates from … 

    …project

As part of the `updateProjectIfDirty` process and inside `updateNonInferredProjectFiles`
TS Server will remove the template files that we added as roots in
`readResource`.
https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2363

The external files are added to the list here so ensuring that the
templates are included in the `getExternalFiles` will prevent this from
happening
https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2395:18
    @atscott
    atscott committed May 12, 2022
    Configuration menu
    Copy the full SHA
    357d1d8 View commit details
    Browse the repository at this point in the history