Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): allow checkNoChanges mode to be tree-shaken in production #45913

Closed
wants to merge 2 commits into from
Closed

perf(core): allow checkNoChanges mode to be tree-shaken in production #45913

wants to merge 2 commits into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented May 6, 2022

This commit guards all logic that exists for the checkNoChanges mode
with ngDevMode checks such that the logic can be tree-shaken.

@JoostK
perf(core): allow checkNoChanges mode to be tree-shaken in production
83f75f3 
This commit guards all logic that exists for the `checkNoChanges` mode
with `ngDevMode` checks such that the logic can be tree-shaken.
@JoostK JoostK marked this pull request as ready for review May 6, 2022 18:03
@JoostK JoostK requested a review from AndrewKushnir May 6, 2022 18:03
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels May 6, 2022
@ngbot ngbot bot added this to the Backlog milestone May 6, 2022
@JoostK
Copy link
Member Author

JoostK commented May 6, 2022

This saves 65514-65165=349 bytes in the todo app (see core/todo/bundle artifact of test job on CircleCI)

AndrewKushnir
AndrewKushnir reviewed May 7, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoostK thanks for the improvement! 👍 I've added a few minor comments.

packages/core/src/render3/instructions/shared.ts Outdated Show resolved Hide resolved
packages/core/src/render3/state.ts Outdated Show resolved Hide resolved
packages/core/src/render3/state.ts Show resolved Hide resolved
packages/core/src/render3/view_ref.ts Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2022
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels May 9, 2022
@ngbot
Copy link

ngbot bot commented May 9, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: aio_preview" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 9, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 75b3d0f.

AndrewKushnir pushed a commit that referenced this pull request May 9, 2022
@JoostK @AndrewKushnir
perf(core): allow checkNoChanges mode to be tree-shaken in producti…
e9317ae 
…on (#45913)

This commit guards all logic that exists for the `checkNoChanges` mode
with `ngDevMode` checks such that the logic can be tree-shaken.

PR Close #45913
@AndrewKushnir
Copy link
Contributor

@JoostK there was a merge conflict with the 13.3.x branch, so this PR was merged into the 14.0.x and main branches only. Could you please create a new PR and target the 13.3.x branch if the change should be included there as well? Thank you.

@JoostK JoostK mentioned this pull request May 9, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoostK @AndrewKushnir