fix(forms): Allow NonNullableFormBuilder to be injected.

[dylhunn]

Based on early feedback, fb.nonNullable.group(...) continues to be clunky for a form with many such groups. Allowing NonNullableFormBuilder to be directly injected enables the following:

class Foo {
  constructor(private fb: NonNullableFormBuilder) {
    this.fb.group({foo: 1});
  }
}

[dylhunn]

@AndrewKushnir I'm actually unsure of how to unit test this, do any suggestions come to mind?

[AndrewKushnir]

I'm actually unsure of how to unit test this, do any suggestions come to mind?

You can add a test like this:

it('should allow NonNullableFormBuilder to be injected', () => {
  @Component({
    standalone: true,
    template: '...',
  })
  class MyComp {
    constructor(public fb: NonNullableFormBuilder) {}
  }

  const fixture = TestBed.createComponent(MyComp);
  fixture.detectChanges();
  expect(fixture.componentInstance.fb).toBeInstanceOf(NonNullableFormBuilder);
}

I'd propose adding a similar test for FormBuilder as well (if we don't have one).

[AndrewKushnir]

Looks good 👍 Just left a couple minor comments.

[AndrewKushnir]

Reviewed-for: public-api

[jessicajaniuk]

reviewed-for: public-api

[dylhunn]

Currently running a standard presubmit.

[dylhunn]

merge-assistance: I'm not sure why pullapprove is fighting me, this is good to go

[AndrewKushnir]

@dylhunn could you please update the code based on #45904 (review)?

[dylhunn]

@AndrewKushnir Whoops, now fixed.

[AndrewKushnir]

This PR was merged into the repository by commit 43ba4ab.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}