fix(bazel): speed up d.ts bundling by configuring worker
#45900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
devversion
force-pushed
the
fix-speed-up-bundling-worker
branch
from
05238a3
to
17c78e1
Compare
Speeds up the `d.ts` bundling by configuring it as a Bazel persistent worker. Also improve logging for the ng packager rule to make it easier to spot which actions/bundles take up significant time. Type bundling will occur for every entry-point so for machines with rather limited cores/threads, this will be useful to save NodeJS boot and resolution time.
devversion
force-pushed
the
fix-speed-up-bundling-worker
branch
from
17c78e1
to
d01b175
Compare
devversion
added
action: merge
AndrewKushnir
added
the
action: presubmit
|
FYI, the NgBot was requesting a presubmit, but we were not syncing anything from those files into g3. I've created a PR to update NgBot config (based on the internal config): #45901. Thank you. |
AndrewKushnir
removed
the
action: presubmit
|
This PR was merged into the repository by commit a6b6590. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 5, 2022
Speeds up the `d.ts` bundling by configuring it as a Bazel persistent worker. Also improve logging for the ng packager rule to make it easier to spot which actions/bundles take up significant time. Type bundling will occur for every entry-point so for machines with rather limited cores/threads, this will be useful to save NodeJS boot and resolution time. PR Close #45900
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up the
d.tsbundling by configuring it as a Bazelpersistent worker. Also improve logging for the ng packager
rule to make it easier to spot which actions/bundles take
up significant time.
Type bundling will occur for every entry-point so for machines
with rather limited cores/threads, this will be useful to save
NodeJS boot and resolution time.